From fe638d05b098e92221c87a5f48816a919a95fbad Mon Sep 17 00:00:00 2001 From: Tangem Date: Tue, 26 Mar 2024 08:47:35 +0000 Subject: [PATCH 1/3] Updated on 2026-08-14 --- .../main/java/com/tangem/feature/swap/ui/StateBuilder.kt | 8 +------- .../com/tangem/feature/swap/viewmodels/SwapViewModel.kt | 1 - 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt b/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt index 4566c64fae..33beaf6e3f 100644 --- a/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt +++ b/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt @@ -1027,7 +1027,6 @@ internal class StateBuilder( fun showSelectProviderBottomSheet( uiState: SwapStateHolder, selectedProviderId: String, - bestRatedProviderId: String, pricesLowerBest: Map, providersStates: Map, unavailableProviders: List, @@ -1035,7 +1034,7 @@ internal class StateBuilder( ): SwapStateHolder { val availableProvidersStates = providersStates.entries .mapNotNull { - it.convertToProviderBottomSheetState(pricesLowerBest, bestRatedProviderId, actions.onProviderSelect) + it.convertToProviderBottomSheetState(pricesLowerBest, actions.onProviderSelect) } .sortedWith(ProviderPercentDiffComparator) val unavailableProviderStates = unavailableProviders.map { @@ -1183,7 +1182,6 @@ internal class StateBuilder( private fun Map.Entry.convertToProviderBottomSheetState( pricesLowerBest: Map, - bestRatedProviderId: String, onProviderSelect: (String) -> Unit, ): ProviderState? { val provider = this.key @@ -1191,7 +1189,6 @@ internal class StateBuilder( is SwapState.EmptyAmountState -> null is SwapState.QuotesLoadedState -> { provider.convertToContentSelectableProviderState( - isBestRate = bestRatedProviderId == provider.providerId, state = state, onProviderClick = onProviderSelect, pricesLowerBest = pricesLowerBest, @@ -1301,7 +1298,6 @@ internal class StateBuilder( } private fun SwapProvider.convertToContentSelectableProviderState( - isBestRate: Boolean, state: SwapState.QuotesLoadedState, selectionType: ProviderState.SelectionType, pricesLowerBest: Map, @@ -1311,8 +1307,6 @@ internal class StateBuilder( val rateString = toTokenInfo.tokenAmount.getFormattedCryptoAmount(toTokenInfo.cryptoCurrencyStatus.currency) val additionalBadge = if (state.permissionState is PermissionDataState.PermissionReadyForRequest) { ProviderState.AdditionalBadge.PermissionRequired - } else if (isBestRate) { - ProviderState.AdditionalBadge.BestTrade } else { ProviderState.AdditionalBadge.Empty } diff --git a/features/swap/presentation/src/main/java/com/tangem/feature/swap/viewmodels/SwapViewModel.kt b/features/swap/presentation/src/main/java/com/tangem/feature/swap/viewmodels/SwapViewModel.kt index 51969a1ec1..d30242c9f2 100644 --- a/features/swap/presentation/src/main/java/com/tangem/feature/swap/viewmodels/SwapViewModel.kt +++ b/features/swap/presentation/src/main/java/com/tangem/feature/swap/viewmodels/SwapViewModel.kt @@ -928,7 +928,6 @@ internal class SwapViewModel @Inject constructor( selectedProviderId = providerId, pricesLowerBest = pricesLowerBest, unavailableProviders = unavailableProviders, - bestRatedProviderId = findBestQuoteProvider(states)?.providerId ?: providerId, providersStates = dataState.lastLoadedSwapStates, ) { uiState = stateBuilder.dismissBottomSheet(uiState) } }, From 4c9d4cc544eae0a3008c0dd7f729b4d15f707465 Mon Sep 17 00:00:00 2001 From: Tangem Date: Mon, 25 Mar 2024 17:54:45 +0000 Subject: [PATCH 2/3] Updated on 2026-08-14 --- .../com/tangem/tap/common/redux/AppReducer.kt | 2 -- .../com/tangem/tap/common/redux/AppState.kt | 4 ---- .../tap/features/home/redux/HomeMiddleware.kt | 23 +++++++++++++++++-- .../tap/features/signin/redux/SignInAction.kt | 12 ---------- .../features/signin/redux/SignInMiddleware.kt | 15 ------------ .../features/signin/redux/SignInReducer.kt | 17 -------------- .../tap/features/signin/redux/SignInState.kt | 8 ------- .../welcome/redux/WelcomeMiddleware.kt | 3 --- 8 files changed, 21 insertions(+), 63 deletions(-) delete mode 100644 app/src/main/java/com/tangem/tap/features/signin/redux/SignInAction.kt delete mode 100644 app/src/main/java/com/tangem/tap/features/signin/redux/SignInMiddleware.kt delete mode 100644 app/src/main/java/com/tangem/tap/features/signin/redux/SignInReducer.kt delete mode 100644 app/src/main/java/com/tangem/tap/features/signin/redux/SignInState.kt diff --git a/app/src/main/java/com/tangem/tap/common/redux/AppReducer.kt b/app/src/main/java/com/tangem/tap/common/redux/AppReducer.kt index a1232dd031..91992dd437 100644 --- a/app/src/main/java/com/tangem/tap/common/redux/AppReducer.kt +++ b/app/src/main/java/com/tangem/tap/common/redux/AppReducer.kt @@ -13,7 +13,6 @@ import com.tangem.tap.features.onboarding.products.wallet.redux.OnboardingWallet import com.tangem.tap.features.saveWallet.redux.SaveWalletReducer import com.tangem.tap.features.send.redux.reducers.SendScreenReducer import com.tangem.tap.features.shop.redux.ShopReducer -import com.tangem.tap.features.signin.redux.SignInReducer import com.tangem.tap.features.tokens.legacy.redux.TokensReducer import com.tangem.tap.features.welcome.redux.WelcomeReducer import com.tangem.tap.proxy.AppStateHolder @@ -40,7 +39,6 @@ fun appReducer(action: Action, state: AppState?, appStateHolder: AppStateHolder) shopState = ShopReducer.reduce(action, state.shopState), welcomeState = WelcomeReducer.reduce(action, state), saveWalletState = SaveWalletReducer.reduce(action, state), - signInState = SignInReducer.reduce(action, state), daggerGraphState = DaggerGraphReducer.reduce(action, state), ) } diff --git a/app/src/main/java/com/tangem/tap/common/redux/AppState.kt b/app/src/main/java/com/tangem/tap/common/redux/AppState.kt index 892271058e..72726532fe 100644 --- a/app/src/main/java/com/tangem/tap/common/redux/AppState.kt +++ b/app/src/main/java/com/tangem/tap/common/redux/AppState.kt @@ -31,8 +31,6 @@ import com.tangem.tap.features.send.redux.middlewares.SendMiddleware import com.tangem.tap.features.send.redux.states.SendState import com.tangem.tap.features.shop.redux.ShopMiddleware import com.tangem.tap.features.shop.redux.ShopState -import com.tangem.tap.features.signin.redux.SignInMiddleware -import com.tangem.tap.features.signin.redux.SignInState import com.tangem.tap.features.tokens.legacy.redux.TokensState import com.tangem.tap.features.wallet.redux.middlewares.TradeCryptoMiddleware import com.tangem.tap.features.welcome.redux.WelcomeMiddleware @@ -59,7 +57,6 @@ data class AppState( val shopState: ShopState = ShopState(), val welcomeState: WelcomeState = WelcomeState(), val saveWalletState: SaveWalletState = SaveWalletState(), - val signInState: SignInState = SignInState(), val daggerGraphState: DaggerGraphState = DaggerGraphState(), ) : StateType { @@ -97,7 +94,6 @@ data class AppState( SaveWalletMiddleware().middleware, LockUserWalletsTimerMiddleware().middleware, AccessCodeRequestPolicyMiddleware().middleware, - SignInMiddleware.middleware, DaggerGraphMiddleware.daggerGraphMiddleware, LegacyMiddleware.legacyMiddleware, TradeCryptoMiddleware.middleware, diff --git a/app/src/main/java/com/tangem/tap/features/home/redux/HomeMiddleware.kt b/app/src/main/java/com/tangem/tap/features/home/redux/HomeMiddleware.kt index 2bec7b7af6..be5b026c2d 100644 --- a/app/src/main/java/com/tangem/tap/features/home/redux/HomeMiddleware.kt +++ b/app/src/main/java/com/tangem/tap/features/home/redux/HomeMiddleware.kt @@ -9,8 +9,10 @@ import com.tangem.core.analytics.models.AnalyticsEvent import com.tangem.core.analytics.models.Basic import com.tangem.core.navigation.AppScreen import com.tangem.core.navigation.NavigationAction +import com.tangem.domain.common.util.cardTypesResolver import com.tangem.domain.models.scan.ScanResponse import com.tangem.domain.userwallets.UserWalletBuilder +import com.tangem.tap.common.analytics.converters.ParamCardCurrencyConverter import com.tangem.tap.common.analytics.events.IntroductionProcess import com.tangem.tap.common.analytics.events.Shop import com.tangem.tap.common.entities.IndeterminateProgressButton @@ -19,7 +21,6 @@ import com.tangem.tap.common.redux.AppState import com.tangem.tap.common.redux.global.GlobalAction import com.tangem.tap.features.home.redux.HomeMiddleware.NEW_BUY_WALLET_URL import com.tangem.tap.features.send.redux.states.ButtonState -import com.tangem.tap.features.signin.redux.SignInAction import com.tangem.tap.preferencesStorage import com.tangem.tap.proxy.redux.DaggerGraphState import com.tangem.tap.scope @@ -113,14 +114,32 @@ private fun proceedWithScanResponse(scanResponse: ScanResponse) = scope.launch { Timber.e(error, "Unable to save user wallet") } .doOnSuccess { + sendSignedInCardAnalyticsEvent(scanResponse) scope.launch { store.onUserWalletSelected(userWallet = userWallet) } } .doOnResult { - store.dispatchOnMain(SignInAction.SetSignInType(Basic.SignedIn.SignInType.Card)) navigateTo(AppScreen.Wallet) } } +private fun sendSignedInCardAnalyticsEvent(scanResponse: ScanResponse) { + val currency = ParamCardCurrencyConverter().convert( + value = scanResponse.cardTypesResolver, + ) + + if (currency != null) { + Analytics.send( + event = Basic.SignedIn( + currency = currency, + batch = scanResponse.card.batchId, + signInType = Basic.SignedIn.SignInType.Card, + walletsCount = userWalletsListManager.walletsCount.toString(), + hasBackup = scanResponse.card.backupStatus?.isActive, + ), + ) + } +} + private suspend fun navigateTo(appScreen: AppScreen) { store.dispatchOnMain(NavigationAction.NavigateTo(appScreen)) delay(timeMillis = 200) diff --git a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInAction.kt b/app/src/main/java/com/tangem/tap/features/signin/redux/SignInAction.kt deleted file mode 100644 index 7978ed3f13..0000000000 --- a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInAction.kt +++ /dev/null @@ -1,12 +0,0 @@ -package com.tangem.tap.features.signin.redux - -import com.tangem.core.analytics.models.Basic -import org.rekotlin.Action - -/** -[REDACTED_AUTHOR] - */ -sealed interface SignInAction : Action { - - data class SetSignInType(val type: Basic.SignedIn.SignInType) : SignInAction -} \ No newline at end of file diff --git a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInMiddleware.kt b/app/src/main/java/com/tangem/tap/features/signin/redux/SignInMiddleware.kt deleted file mode 100644 index 1f44dff0f7..0000000000 --- a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInMiddleware.kt +++ /dev/null @@ -1,15 +0,0 @@ -package com.tangem.tap.features.signin.redux - -import com.tangem.tap.common.redux.AppState -import org.rekotlin.Middleware - -/** -[REDACTED_AUTHOR] - */ -object SignInMiddleware { - val middleware: Middleware = { _, _ -> - { next -> - { action -> next(action) } - } - } -} \ No newline at end of file diff --git a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInReducer.kt b/app/src/main/java/com/tangem/tap/features/signin/redux/SignInReducer.kt deleted file mode 100644 index 3d5910774d..0000000000 --- a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInReducer.kt +++ /dev/null @@ -1,17 +0,0 @@ -package com.tangem.tap.features.signin.redux - -import com.tangem.tap.common.redux.AppState -import org.rekotlin.Action - -/** -[REDACTED_AUTHOR] - */ -object SignInReducer { - fun reduce(action: Action, state: AppState): SignInState { - if (action !is SignInAction) return state.signInState - - return when (action) { - is SignInAction.SetSignInType -> state.signInState.copy(type = action.type) - } - } -} \ No newline at end of file diff --git a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInState.kt b/app/src/main/java/com/tangem/tap/features/signin/redux/SignInState.kt deleted file mode 100644 index 27858a8ad7..0000000000 --- a/app/src/main/java/com/tangem/tap/features/signin/redux/SignInState.kt +++ /dev/null @@ -1,8 +0,0 @@ -package com.tangem.tap.features.signin.redux - -import com.tangem.core.analytics.models.Basic - -/** -[REDACTED_AUTHOR] - */ -data class SignInState(val type: Basic.SignedIn.SignInType? = null) \ No newline at end of file diff --git a/app/src/main/java/com/tangem/tap/features/welcome/redux/WelcomeMiddleware.kt b/app/src/main/java/com/tangem/tap/features/welcome/redux/WelcomeMiddleware.kt index ca7d00d461..e2ff46f387 100644 --- a/app/src/main/java/com/tangem/tap/features/welcome/redux/WelcomeMiddleware.kt +++ b/app/src/main/java/com/tangem/tap/features/welcome/redux/WelcomeMiddleware.kt @@ -25,7 +25,6 @@ import com.tangem.tap.common.extensions.onUserWalletSelected import com.tangem.tap.common.redux.AppState import com.tangem.tap.features.intentHandler.handlers.BackgroundScanIntentHandler import com.tangem.tap.features.intentHandler.handlers.WalletConnectLinkIntentHandler -import com.tangem.tap.features.signin.redux.SignInAction import com.tangem.tap.proxy.redux.DaggerGraphState import kotlinx.coroutines.CoroutineScope import kotlinx.coroutines.launch @@ -98,7 +97,6 @@ internal class WelcomeMiddleware { signInType = Basic.SignedIn.SignInType.Biometric, ) - store.dispatchWithMain(SignInAction.SetSignInType(Basic.SignedIn.SignInType.Biometric)) store.dispatchWithMain(NavigationAction.NavigateTo(AppScreen.Wallet)) store.dispatchWithMain(WelcomeAction.ProceedWithBiometrics.Success) store.onUserWalletSelected(userWallet = selectedUserWallet) @@ -128,7 +126,6 @@ internal class WelcomeMiddleware { .doOnSuccess { sendSignedInAnalyticsEvent(scanResponse = scanResponse, signInType = Basic.SignedIn.SignInType.Card) - store.dispatchWithMain(SignInAction.SetSignInType(Basic.SignedIn.SignInType.Card)) store.dispatchWithMain(NavigationAction.NavigateTo(AppScreen.Wallet)) store.dispatchWithMain(WelcomeAction.ProceedWithCard.Success) store.onUserWalletSelected(userWallet = userWallet) From 4dba6e3c3dd192c8a777b8696fa99c441887009d Mon Sep 17 00:00:00 2001 From: Tangem Date: Tue, 26 Mar 2024 12:54:37 +0000 Subject: [PATCH 3/3] Updated on 2026-08-14 --- .../java/com/tangem/feature/swap/ui/StateBuilder.kt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt b/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt index 33beaf6e3f..1761af22d7 100644 --- a/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt +++ b/features/swap/presentation/src/main/java/com/tangem/feature/swap/ui/StateBuilder.kt @@ -410,11 +410,11 @@ internal class StateBuilder( fromToken: CryptoCurrency, warnings: MutableList, ) { - val feeEnoughState = quoteModel.preparedSwapConfigState.feeState - if (feeEnoughState is SwapFeeState.NotEnough && - quoteModel.preparedSwapConfigState.isBalanceEnough && - quoteModel.permissionState !is PermissionDataState.PermissionLoading - ) { + val feeEnoughState = quoteModel.preparedSwapConfigState.feeState as? SwapFeeState.NotEnough ?: return + val needShowCoverWarning = quoteModel.preparedSwapConfigState.isBalanceEnough && + quoteModel.permissionState !is PermissionDataState.PermissionLoading && + feeEnoughState.feeCurrency != fromToken + if (needShowCoverWarning) { warnings.add( SwapWarning.UnableToCoverFeeWarning( createUnableToCoverFeeNotificationConfig(