diff --git a/app/src/main/java/com/tangem/tap/TangemApplication.kt b/app/src/main/java/com/tangem/tap/TangemApplication.kt
index 7804a24b4f..2815df1738 100644
--- a/app/src/main/java/com/tangem/tap/TangemApplication.kt
+++ b/app/src/main/java/com/tangem/tap/TangemApplication.kt
@@ -328,7 +328,7 @@ open class TangemApplication : Application(), ImageLoaderFactory, Configuration.
ExceptionHandler.append(blockchainExceptionHandler)
- if (LogConfig.network.blockchainSdkNetwork) {
+ if (LogConfig.network.isBlockchainSdkNetworkLogEnabled) {
BlockchainSdkRetrofitBuilder.interceptors = listOf(
createNetworkLoggingInterceptor(),
ChuckerInterceptor(this),
diff --git a/app/src/main/java/com/tangem/tap/common/analytics/handlers/amplitude/AmplitudeAnalyticsHandler.kt b/app/src/main/java/com/tangem/tap/common/analytics/handlers/amplitude/AmplitudeAnalyticsHandler.kt
index d28504b612..1fdb08a185 100644
--- a/app/src/main/java/com/tangem/tap/common/analytics/handlers/amplitude/AmplitudeAnalyticsHandler.kt
+++ b/app/src/main/java/com/tangem/tap/common/analytics/handlers/amplitude/AmplitudeAnalyticsHandler.kt
@@ -29,7 +29,7 @@ class AmplitudeAnalyticsHandler(
class Builder : AnalyticsHandlerBuilder {
override fun build(data: AnalyticsHandlerBuilder.Data): AnalyticsHandler {
return AmplitudeAnalyticsHandler(
- client = if (data.logConfig.amplitude) {
+ client = if (data.logConfig.isAmplitudeLogEnabled) {
AmplitudeLogClient(data.jsonConverter)
} else {
AmplitudeClient(data.application, data.config.amplitudeApiKey)
diff --git a/app/src/main/java/com/tangem/tap/common/analytics/handlers/firebase/FirebaseAnalyticsHandler.kt b/app/src/main/java/com/tangem/tap/common/analytics/handlers/firebase/FirebaseAnalyticsHandler.kt
index fbea91a9f4..7e7106ebb4 100644
--- a/app/src/main/java/com/tangem/tap/common/analytics/handlers/firebase/FirebaseAnalyticsHandler.kt
+++ b/app/src/main/java/com/tangem/tap/common/analytics/handlers/firebase/FirebaseAnalyticsHandler.kt
@@ -49,7 +49,7 @@ class FirebaseAnalyticsHandler(
class Builder : AnalyticsHandlerBuilder {
override fun build(data: AnalyticsHandlerBuilder.Data): AnalyticsHandler? = when {
!data.isDebug -> FirebaseClient()
- data.isDebug && data.logConfig.firebase -> FirebaseLogClient(data.jsonConverter)
+ data.isDebug && data.logConfig.isFirebaseLogEnabled -> FirebaseLogClient(data.jsonConverter)
else -> null
}?.let { FirebaseAnalyticsHandler(it) }
}
diff --git a/app/src/main/java/com/tangem/tap/routing/utils/ChildFactory.kt b/app/src/main/java/com/tangem/tap/routing/utils/ChildFactory.kt
index 57dc3d376e..47c2c3ad6e 100644
--- a/app/src/main/java/com/tangem/tap/routing/utils/ChildFactory.kt
+++ b/app/src/main/java/com/tangem/tap/routing/utils/ChildFactory.kt
@@ -565,7 +565,7 @@ internal class ChildFactory @Inject constructor(
params = CreateWalletBackupComponent.Params(
userWalletId = route.userWalletId,
isUpgradeFlow = route.isUpgradeFlow,
- shouldSetAccessCode = route.setAccessCode,
+ shouldSetAccessCode = route.shouldSetAccessCode,
analyticsSource = route.analyticsSource,
analyticsAction = route.analyticsAction,
),
diff --git a/common/routing/detekt-baseline-debug.xml b/common/routing/detekt-baseline-debug.xml
deleted file mode 100644
index 84f08bf7e3..0000000000
--- a/common/routing/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:AppRoute.kt$AppRoute.CreateWalletBackup$val setAccessCode: Boolean = false
- NestedScopeFunctions:PayloadToDeeplinkConverter.kt$PayloadToDeeplinkConverter$let { addQueryParam(NAME_KEY, it) }
- NestedScopeFunctions:PayloadToDeeplinkConverter.kt$PayloadToDeeplinkConverter$let { addQueryParam(TRANSACTION_ID_KEY, it) }
-
-
diff --git a/common/routing/src/main/kotlin/com/tangem/common/routing/AppRoute.kt b/common/routing/src/main/kotlin/com/tangem/common/routing/AppRoute.kt
index f1c07144f6..fe5adba5c2 100644
--- a/common/routing/src/main/kotlin/com/tangem/common/routing/AppRoute.kt
+++ b/common/routing/src/main/kotlin/com/tangem/common/routing/AppRoute.kt
@@ -368,7 +368,7 @@ sealed class AppRoute(val path: String) : Route {
val analyticsSource: String,
val analyticsAction: String,
val isUpgradeFlow: Boolean = false,
- val setAccessCode: Boolean = false,
+ val shouldSetAccessCode: Boolean = false,
) : AppRoute(path = "/create_wallet_backup/${userWalletId.stringValue}")
@Serializable
diff --git a/common/routing/src/main/kotlin/com/tangem/common/routing/deeplink/PayloadToDeeplinkConverter.kt b/common/routing/src/main/kotlin/com/tangem/common/routing/deeplink/PayloadToDeeplinkConverter.kt
index ff88b96b22..5bee03bf9b 100644
--- a/common/routing/src/main/kotlin/com/tangem/common/routing/deeplink/PayloadToDeeplinkConverter.kt
+++ b/common/routing/src/main/kotlin/com/tangem/common/routing/deeplink/PayloadToDeeplinkConverter.kt
@@ -55,8 +55,12 @@ object PayloadToDeeplinkConverter : Converter, String?> {
addQueryParam(DERIVATION_PATH_KEY, derivationPath)
}
- transactionId?.let { addQueryParam(TRANSACTION_ID_KEY, it) }
- name?.let { addQueryParam(NAME_KEY, it) }
+ if (transactionId != null) {
+ addQueryParam(TRANSACTION_ID_KEY, transactionId)
+ }
+ if (name != null) {
+ addQueryParam(NAME_KEY, name)
+ }
}.build()
}
diff --git a/data/feedback/detekt-baseline-debug.xml b/data/feedback/detekt-baseline-debug.xml
deleted file mode 100644
index d10388bff4..0000000000
--- a/data/feedback/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,7 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:DefaultFeedbackRepository.kt$DefaultFeedbackRepository$private val useNewUserWalletsRepository: Boolean
-
-
diff --git a/data/feedback/src/main/java/com/tangem/data/feedback/DefaultFeedbackRepository.kt b/data/feedback/src/main/java/com/tangem/data/feedback/DefaultFeedbackRepository.kt
index dcadace780..24ce5d7b07 100644
--- a/data/feedback/src/main/java/com/tangem/data/feedback/DefaultFeedbackRepository.kt
+++ b/data/feedback/src/main/java/com/tangem/data/feedback/DefaultFeedbackRepository.kt
@@ -26,7 +26,7 @@ import java.io.File
*
* @property appLogsStore app logs store
* @property userWalletsListManager user wallets list manager
- * @property useNewUserWalletsRepository flag to use new user wallets repository
+ * @property shouldUseNewUserWalletsRepository flag to use new user wallets repository
* @property userWalletsListRepository user wallets repository
* @property walletManagersStore wallet managers store
* @property emailSender email sender
@@ -37,7 +37,7 @@ import java.io.File
@Suppress("LongParameterList")
internal class DefaultFeedbackRepository(
private val appLogsStore: AppLogsStore,
- private val useNewUserWalletsRepository: Boolean,
+ private val shouldUseNewUserWalletsRepository: Boolean,
private val userWalletsListRepository: UserWalletsListRepository,
private val userWalletsListManager: UserWalletsListManager,
private val walletManagersStore: WalletManagersStore,
@@ -126,7 +126,7 @@ internal class DefaultFeedbackRepository(
}
private suspend fun getUserWalletById(userWalletId: UserWalletId): UserWallet? {
- return if (useNewUserWalletsRepository) {
+ return if (shouldUseNewUserWalletsRepository) {
userWalletsListRepository.userWalletsSync().find { it.walletId == userWalletId }
} else {
userWalletsListManager.userWalletsSync.find { it.walletId == userWalletId }
@@ -134,7 +134,7 @@ internal class DefaultFeedbackRepository(
}
private fun totalUserWallets(): Int {
- return if (useNewUserWalletsRepository) {
+ return if (shouldUseNewUserWalletsRepository) {
userWalletsListRepository.userWallets.value?.size ?: 0
} else {
userWalletsListManager.walletsCount
diff --git a/data/feedback/src/main/java/com/tangem/data/feedback/di/FeedbackModule.kt b/data/feedback/src/main/java/com/tangem/data/feedback/di/FeedbackModule.kt
index 63f1b43180..d6ecc8ef1e 100644
--- a/data/feedback/src/main/java/com/tangem/data/feedback/di/FeedbackModule.kt
+++ b/data/feedback/src/main/java/com/tangem/data/feedback/di/FeedbackModule.kt
@@ -42,7 +42,7 @@ internal object FeedbackModule {
emailSender = emailSender,
appVersionProvider = appVersionProvider,
userWalletsListRepository = userWalletsListRepository,
- useNewUserWalletsRepository = hotWalletFeatureToggles.isHotWalletEnabled,
+ shouldUseNewUserWalletsRepository = hotWalletFeatureToggles.isHotWalletEnabled,
getSelectedWalletUseCase = getSelectedWalletUseCase,
)
}
diff --git a/data/promo/detekt-baseline-debug.xml b/data/promo/detekt-baseline-debug.xml
deleted file mode 100644
index 7ac3d42cb4..0000000000
--- a/data/promo/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-
-
-
-
- SuspendFunSwallowedCancellation:DefaultPromoRepository.kt$DefaultPromoRepository$runCatching
- SuspendFunWithFlowReturnType:DefaultPromoRepository.kt$DefaultPromoRepository$suspend
-
-
diff --git a/data/promo/src/main/java/com/tangem/data/promo/DefaultPromoRepository.kt b/data/promo/src/main/java/com/tangem/data/promo/DefaultPromoRepository.kt
index 86c501406d..beb55966c3 100644
--- a/data/promo/src/main/java/com/tangem/data/promo/DefaultPromoRepository.kt
+++ b/data/promo/src/main/java/com/tangem/data/promo/DefaultPromoRepository.kt
@@ -19,6 +19,7 @@ import com.tangem.domain.promo.models.StoryContent
import com.tangem.feature.referral.domain.ReferralRepository
import com.tangem.utils.coroutines.CoroutineDispatcherProvider
import com.tangem.utils.coroutines.runCatching
+import com.tangem.utils.coroutines.runSuspendCatching
import kotlinx.coroutines.flow.*
import kotlinx.coroutines.withContext
import kotlinx.coroutines.withTimeoutOrNull
@@ -42,7 +43,7 @@ internal class DefaultPromoRepository(
.distinctUntilChanged()
.map { shouldShow ->
when (promoId) {
- PromoId.Referral -> runCatching {
+ PromoId.Referral -> runSuspendCatching {
!referralRepository.isReferralParticipant(userWalletId) && shouldShow
}.getOrDefault(false)
PromoId.Sepa -> {
@@ -81,7 +82,7 @@ internal class DefaultPromoRepository(
appPreferencesStore.store(PreferencesKeys.getShouldShowPromoKey(promoId = promoId.name), false)
}
- override suspend fun isMarketsStakingNotificationHideClicked(): Flow {
+ override fun isMarketsStakingNotificationHideClicked(): Flow {
return appPreferencesStore.get(
key = PreferencesKeys.MARKETS_STAKING_NOTIFICATION_HIDE_CLICKED_KEY,
default = false,
@@ -105,7 +106,7 @@ internal class DefaultPromoRepository(
val storedPromo = promoStoriesStore.getSyncOrNull(storyId = id)
// Get last stored promo by id if possible or get from network
val story = if (storedPromo == null && refresh) {
- val storyContent = runCatching {
+ val storyContent = runSuspendCatching {
// Important to return
withTimeoutOrNull(STORIES_LOAD_DELAY) {
tangemApi.getStoryById(storyId = id).getOrThrow()
diff --git a/data/transaction/detekt-baseline-debug.xml b/data/transaction/detekt-baseline-debug.xml
deleted file mode 100644
index dd2976b413..0000000000
--- a/data/transaction/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-
-
-
-
- CastNullableToNonNullableType:DefaultTransactionRepository.kt$DefaultTransactionRepository$as
- NoNameShadowing:DefaultTransactionRepository.kt$DefaultTransactionRepository$amount
- NoNameShadowing:DefaultTransactionRepository.kt$DefaultTransactionRepository$destination
- NullableBooleanCheck:DefaultWalletAddressServiceRepository.kt$DefaultWalletAddressServiceRepository$(walletManager as? NearWalletManager)?.validateAddress(address) ?: false
- NullableToStringCall:DefaultTransactionRepository.kt$DefaultTransactionRepository$${walletManager?.wallet?.blockchain}
-
-
diff --git a/data/transaction/src/main/java/com/tangem/data/transaction/DefaultTransactionRepository.kt b/data/transaction/src/main/java/com/tangem/data/transaction/DefaultTransactionRepository.kt
index 26cb2d893e..f7c4ffff50 100644
--- a/data/transaction/src/main/java/com/tangem/data/transaction/DefaultTransactionRepository.kt
+++ b/data/transaction/src/main/java/com/tangem/data/transaction/DefaultTransactionRepository.kt
@@ -38,7 +38,7 @@ import timber.log.Timber
import java.math.BigDecimal
import java.math.BigInteger
-@Suppress("LargeClass")
+@Suppress("LargeClass", "NullableToStringCall")
internal class DefaultTransactionRepository(
private val tangemTechApi: TangemTechApi,
private val walletManagersFacade: WalletManagersFacade,
@@ -64,12 +64,12 @@ internal class DefaultTransactionRepository(
val extras = txExtras ?: getMemoExtras(networkId = network.rawId, memo)
- val destination = if (amount.type is AmountType.TokenYieldSupply) {
+ val patchedDestination = if (amount.type is AmountType.TokenYieldSupply) {
walletManager.getYieldModuleAddress()
} else {
destination
}
- val amount = if (amount.type is AmountType.TokenYieldSupply) {
+ val patchedAmount = if (amount.type is AmountType.TokenYieldSupply) {
amount.copy(value = BigDecimal.ZERO)
} else {
amount
@@ -77,17 +77,17 @@ internal class DefaultTransactionRepository(
return@withContext if (fee != null) {
walletManager.createTransaction(
- amount = amount,
+ amount = patchedAmount,
fee = fee,
- destination = destination,
+ destination = patchedDestination,
).copy(
extras = extras,
)
} else {
TransactionData.Uncompiled(
- amount = amount,
+ amount = patchedAmount,
sourceAddress = walletManager.wallet.address,
- destinationAddress = destination,
+ destinationAddress = patchedDestination,
extras = extras,
fee = null,
)
@@ -288,7 +288,7 @@ internal class DefaultTransactionRepository(
blockchain = blockchain,
derivationPath = network.derivationPath.value,
)
- (walletManager as TransactionSender).send(txData, signer)
+ (requireNotNull(walletManager) as TransactionSender).send(txData, signer)
}
override suspend fun sendMultipleTransactions(
@@ -304,7 +304,7 @@ internal class DefaultTransactionRepository(
blockchain = blockchain,
derivationPath = network.derivationPath.value,
)
- (walletManager as TransactionSender).sendMultiple(txsData, signer, sendMode)
+ (requireNotNull(walletManager) as TransactionSender).sendMultiple(txsData, signer, sendMode)
}
override fun createTransactionDataExtras(
diff --git a/data/transaction/src/main/java/com/tangem/data/transaction/DefaultWalletAddressServiceRepository.kt b/data/transaction/src/main/java/com/tangem/data/transaction/DefaultWalletAddressServiceRepository.kt
index 23990f9704..49244f2da1 100644
--- a/data/transaction/src/main/java/com/tangem/data/transaction/DefaultWalletAddressServiceRepository.kt
+++ b/data/transaction/src/main/java/com/tangem/data/transaction/DefaultWalletAddressServiceRepository.kt
@@ -89,7 +89,7 @@ class DefaultWalletAddressServiceRepository(
blockchain = blockchain,
derivationPath = network.derivationPath.value,
) ?: return@withContext false
- (walletManager as? NearWalletManager)?.validateAddress(address) ?: false
+ (walletManager as? NearWalletManager)?.validateAddress(address) == true
} else {
blockchain.validateAddress(address)
}
diff --git a/detekt_baseline_report.txt b/detekt_baseline_report.txt
index c9844f8fd5..f0dde73ad3 100644
--- a/detekt_baseline_report.txt
+++ b/detekt_baseline_report.txt
@@ -1,7 +1,7 @@
==========================================
Detekt Baseline Updater & Issue Counter
==========================================
-Date: 2025-12-02 18:48:27
+Date: 2025-12-03 22:08:49
Step 1: Running detekt to check for new issues...
@@ -17,13 +17,13 @@ Counting issues in baseline files...
==========================================
Summary:
- Total Issues: 1424
- Modules with Issues: 62
- Average Issues per Module: 22
+ Total Issues: 1385
+ Modules with Issues: 50
+ Average Issues per Module: 27
Progress:
- Fixed: 378 out of 1802 (20%)
- Remaining: 1424
+ Fixed: 417 out of 1802 (23%)
+ Remaining: 1385
==========================================
All Modules with Issues (sorted by count)
@@ -32,7 +32,7 @@ All Modules with Issues (sorted by count)
Module Issues
────────────────────────────────────────────────────────────────
features/markets/impl 148
-features/wallet/impl 146
+features/wallet/impl 145
features/onboarding-v2/impl 130
features/swap/impl 67
features/send-v2/impl 57
@@ -76,21 +76,9 @@ libs/visa 5
features/send-v2/api 5
features/home/impl 5
domain/markets 5
-domain/legacy 5
-data/transaction 5
data/account 5
-features/referral/domain 4
-features/biometry/impl 4
data/tokens 4
-features/txhistory/impl 3
-features/tangempay/onboarding/impl 3
-features/create-wallet-start/impl 3
-domain/manage-tokens 3
data/wallet-manager 3
data/manage-tokens 3
-common/routing 3
-features/account/api 2
-data/promo 2
core/config-toggles 2
-data/feedback 1
────────────────────────────────────────────────────────────────
\ No newline at end of file
diff --git a/domain/demo/models/src/main/kotlin/com/tangem/domain/demo/models/DemoConfigCardIds.kt b/domain/demo/models/src/main/kotlin/com/tangem/domain/demo/models/DemoConfigCardIds.kt
new file mode 100644
index 0000000000..c9a8d5dc7f
--- /dev/null
+++ b/domain/demo/models/src/main/kotlin/com/tangem/domain/demo/models/DemoConfigCardIds.kt
@@ -0,0 +1,397 @@
+package com.tangem.domain.demo.models
+
+@Suppress("LargeClass")
+internal object DemoConfigCardIds {
+
+ val releaseDemoCardIds = mutableListOf(
+ // === Not from the Google Sheet table ===
+ "AC01000000041225",
+ "AC01000000041472",
+ "AB01000000046498",
+ "AB01000000049608",
+ "AB01000000049574",
+ "AB01000000046704",
+ "AB02000000051000",
+ "AB02000000050911",
+
+ // === Mvideo ===
+ // Wallet
+ "AC01000000045754",
+ "AC01000000041662",
+ "AC01000000041647",
+ "AC01000000041209",
+ "AC01000000042462",
+ "AC01000000041100",
+ "AC01000000041621",
+ "AC01000000045960",
+ "AC01000000041092",
+ "AC01000000041217",
+ "AC01000000013489",
+ "AC01000000028610",
+ "AC01000000028701",
+ "AC01000000028578",
+ "AC01000000027281",
+ "AC01000000027216",
+ "AC01000000028594",
+ "AC01000000028602",
+ "AC01000000028636",
+ "AC01000000013968",
+ "AC01000000027208",
+ "AC01000000013471",
+ "AC01000000028586",
+ "AC01000000013703",
+ "AC01000000028628",
+ "AC01000000028693",
+ "AC01000000028685",
+ "AC01000000013950",
+ "AC01000000013828",
+ "AC01000000013497",
+ "AC01000000013836",
+ "AC01000000013505",
+ "AC03000000046693",
+ "AC03000000046685",
+ "AC03000000046677",
+ "AC03000000046669",
+ "AC03000000046651",
+ "AC03000000046644",
+ "AC03000000046636",
+ "AC03000000046628",
+ "AC03000000046610",
+ "AC03000000046602",
+ "AC03000000046594",
+ "AC03000000046586",
+ "AC03000000046578",
+ "AC03000000046560",
+ "AC03000000046552",
+ "AC03000000046545",
+ "AC03000000046537",
+ "AC03000000046529",
+ "AC03000000046511",
+ "AC03000000046800",
+ "AC03000000046792",
+ "AC03000000046784",
+ "AC03000000046776",
+ "AC03000000046768",
+ "AC03000000046750",
+ "AC03000000046743",
+ "AC03000000046735",
+ "AC03000000046727",
+ "AC03000000046446",
+ "AC03000000046438",
+ "AC03000000046412",
+ "AC03000000046388",
+ "AC03000000046370",
+ "AC03000000046354",
+ "AC03000000046347",
+ "AC03000000046339",
+ "AC03000000046321",
+ "AC03000000046172",
+ "AC03000000046396",
+ "AC03000000046404",
+ "AC03000000046701",
+ "AC03000000046420",
+ "AC03000000046719",
+ "AC03000000046503",
+ "AC03000000046495",
+ "AC03000000046487",
+ "AC03000000046362",
+ "AC03000000046479",
+ "AC03000000046461",
+ "AC03000000046453",
+
+ // Note BTC
+ "AB01000000059608",
+ "AB01000000046647",
+ "AB01000000046571",
+ "AB01000000046746",
+ "AB01000000059574",
+ "AB01000000046753",
+ "AB01000000046605",
+ "AB01000000046761",
+ "AB01000000046720",
+ "AB01000000046530",
+ "AB01000000016475",
+ "AB01000000016483",
+ "AB01000000016491",
+ "AB01000000020709",
+ "AB01000000020717",
+ "AB01000000015550",
+ "AB01000000015394",
+ "AB01000000016079",
+ "AB01000000016087",
+ "AB01000000016095",
+ "AB01000000020915",
+ "AB01000000017184",
+ "AB01000000020907",
+ "AB01000000017192",
+ "AB01000000016210",
+ "AB01000000016111",
+ "AB01000000016103",
+ "AB01000000015766",
+ "AB01000000015774",
+ "AB01000000015782",
+ "AB01000000022598",
+ "AB01000000022580",
+ "AB01000000005688",
+ "AB07000000005696",
+ "AB07000000005902",
+ "AB07000000005910",
+ "AB07000000005928",
+ "AB07000000005936",
+ "AB07000000005944",
+ "AB07000000005993",
+ "AB07000000005985",
+ "AB07000000005977",
+ "AB07000000005969",
+ "AB07000000005951",
+ "AB07000000005605",
+ "AB07000000005803",
+ "AB07000000005811",
+ "AB07000000005829",
+ "AB07000000005837",
+ "AB07000000005845",
+ "AB07000000005852",
+ "AB07000000005860",
+ "AB07000000005878",
+ "AB07000000005886",
+ "AB07000000005894",
+ "AB07000000005704",
+ "AB07000000005712",
+ "AB07000000005720",
+ "AB07000000005738",
+ "AB07000000005746",
+ "AB07000000005514",
+ "AB07000000005522",
+ "AB07000000005563",
+ "AB07000000005571",
+ "AB07000000005589",
+ "AB07000000005597",
+ "AB07000000005613",
+ "AB07000000005621",
+ "AB07000000005639",
+ "AB07000000005647",
+ "AB07000000005654",
+ "AB07000000005662",
+ "AB07000000005670",
+ "AB07000000005530",
+ "AB07000000005548",
+ "AB07000000005555",
+ "AB07000000005753",
+ "AB07000000005761",
+ "AB07000000005779",
+ "AB07000000005787",
+ "AB07000000005795",
+ "AB07000000005506",
+
+ // Note ETH
+ "AB02000000051083",
+ "AB02000000051059",
+ "AB02000000051158",
+ "AB02000000050986",
+ "AB02000000051026",
+ "AB02000000050960",
+ "AB02000000051042",
+ "AB02000000051091",
+ "AB02000000051034",
+ "AB02000000051133",
+ "AB02000000019924",
+ "AB02000000019932",
+ "AB02000000022092",
+ "AB02000000022282",
+ "AB02000000023983",
+ "AB02000000023439",
+ "AB02000000020328",
+ "AB02000000020310",
+ "AB02000000021565",
+ "AB02000000022357",
+ "AB02000000023355",
+ "AB02000000022324",
+ "AB02000000022100",
+ "AB02000000019999",
+ "AB02000000020013",
+ "AB02000000020005",
+ "AB02000000020021",
+ "AB02000000020039",
+ "AB02000000020278",
+ "AB02000000020252",
+ "AB02000000018652",
+ "AB02000000018561",
+ "AB08000000009481",
+ "AB08000000009473",
+ "AB08000000009705",
+ "AB08000000009897",
+ "AB08000000009689",
+ "AB08000000009671",
+ "AB08000000009465",
+ "AB08000000009457",
+ "AB08000000009440",
+ "AB08000000009432",
+ "AB08000000009424",
+ "AB08000000009416",
+ "AB08000000009408",
+ "AB08000000009390",
+ "AB08000000009374",
+ "AB08000000009382",
+ "AB08000000009267",
+ "AB08000000009275",
+ "AB08000000009283",
+ "AB08000000009291",
+ "AB08000000009309",
+ "AB08000000009317",
+ "AB08000000009325",
+ "AB08000000009333",
+ "AB08000000009341",
+ "AB08000000009358",
+ "AB08000000009366",
+ "AB08000000009077",
+ "AB08000000009143",
+ "AB08000000009168",
+ "AB08000000009184",
+ "AB08000000009192",
+ "AB08000000009200",
+ "AB08000000009226",
+ "AB08000000009218",
+ "AB08000000009234",
+ "AB08000000009242",
+ "AB08000000008574",
+ "AB08000000009069",
+ "AB08000000008525",
+ "AB08000000009051",
+ "AB08000000009135",
+ "AB08000000009150",
+ "AB08000000009176",
+ "AB08000000009085",
+ "AB08000000009093",
+ "AB08000000009101",
+ "AB08000000009119",
+ "AB08000000009127",
+ "AB08000000009259",
+
+ // === Technopark ===
+ // Wallet
+ "AC01000000044120",
+ "AC01000000044997",
+ "AC01000000044989",
+ "AC01000000043494",
+ "AC01000000043486",
+ "AC01000000044187",
+ "AC01000000043148",
+ "AC01000000044013",
+ "AC01000000043973",
+ "AC01000000044815",
+ "AC01000000044807",
+ "AC01000000043809",
+ "AC01000000043833",
+ "AC01000000043460",
+ "AC01000000043064",
+ "AC01000000044138",
+ "AC01000000044500",
+ "AC01000000044492",
+ "AC01000000044260",
+ "AC01000000044278",
+
+ // Note BTC
+ "AB01000000049864",
+ "AB01000000053239",
+ "AB01000000053056",
+ "AB01000000054237",
+ "AB01000000054245",
+ "AB01000000054211",
+ "AB01000000054229",
+ "AB01000000053189",
+ "AB01000000054195",
+ "AB01000000050797",
+ "AB01000000053833",
+ "AB01000000052124",
+ "AB01000000051605",
+ "AB01000000052223",
+ "AB01000000052207",
+ "AB01000000052199",
+ "AB01000000047785",
+ "AB01000000047850",
+ "AB01000000047868",
+ "AB01000000048288",
+
+ // Note ETH
+ "AB02000000049715",
+ "AB02000000049848",
+ "AB02000000049814",
+ "AB02000000049863",
+ "AB02000000049871",
+ "AB02000000049855",
+ "AB02000000049285",
+ "AB02000000049277",
+ "AB02000000049558",
+ "AB02000000049889",
+ "AB02000000049988",
+ "AB02000000049707",
+ "AB02000000049699",
+ "AB02000000049897",
+ "AB02000000049905",
+ "AB02000000049913",
+ "AB02000000049251",
+ "AB02000000049533",
+ "AB02000000049541",
+ "AB02000000049830",
+ // === more cids ===
+ "AC03000000091418",
+ "AC03000000091400",
+ "AC03000000099007",
+ "AC03000000098991",
+ "AC03000000098942",
+ "AC03000000091715",
+ "AC03000000091301",
+ "AC03000000091343",
+ "AB01000000055705",
+ "AB01000000052918",
+ "AB01000000047710",
+ "AB01000000052306",
+ "AB01000000047645",
+ "AB01000000048957",
+ "AB01000000052900",
+ "AB01000000050391",
+ "AB01000000047363",
+ "AB02000000053998",
+ "AB02000000019809",
+ "AB02000000020872",
+ "AB02000000022027",
+ "AB02000000058955",
+ "AB02000000053253",
+ "AB02000000048063",
+ "AB02000000023736",
+ "AB02000000058187",
+ "AB02000000000007",
+ "AC03000000076229",
+ "AF04000000000118",
+
+ // Wallet 2
+ "AF04000000012006",
+ "AF04000000012014",
+ "AF04000000012022",
+ "AF04000000012030",
+ "AF15000000257889",
+ "AF15000000257897",
+ "AF15000000637809",
+ "AF15000000640282",
+ "AF15000001187424",
+ "AF15000001187408",
+ "AF15000001187416",
+ "AF15000001195781",
+ "AF15000001195773",
+ "AF15000001195799",
+ // Wallet 2 QA
+ "AF12345678912346",
+ "AF12345678912361",
+ "AF10100000000076",
+ "AF10100000000084",
+ )
+
+ val testDemoCardIds = listOf(
+ "FB20000000000186", // Note ETH
+ "FB10000000000196", // Note BTC
+ "FB30000000000176", // Wallet
+ "FB04000000000152", // Wallet 2
+ )
+
+ val debugTestDemoCardIds = emptyList()
+}
\ No newline at end of file
diff --git a/domain/legacy/detekt-baseline-debug.xml b/domain/legacy/detekt-baseline-debug.xml
deleted file mode 100644
index 3d02fabec6..0000000000
--- a/domain/legacy/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,11 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:LogConfig.kt$AnalyticsHandlersLogConfig$val amplitude: Boolean = BuildConfig.LOG_ENABLED
- BooleanPropertyNaming:LogConfig.kt$AnalyticsHandlersLogConfig$val appsflyer: Boolean = BuildConfig.LOG_ENABLED
- BooleanPropertyNaming:LogConfig.kt$AnalyticsHandlersLogConfig$val firebase: Boolean = BuildConfig.LOG_ENABLED
- BooleanPropertyNaming:LogConfig.kt$LogConfig$val storeAction: Boolean = BuildConfig.LOG_ENABLED
- BooleanPropertyNaming:LogConfig.kt$NetworkLogConfig$val blockchainSdkNetwork: Boolean = BuildConfig.LOG_ENABLED
-
-
diff --git a/domain/legacy/src/main/java/com/tangem/domain/common/LogConfig.kt b/domain/legacy/src/main/java/com/tangem/domain/common/LogConfig.kt
index 3adab018df..1a8068cfb5 100644
--- a/domain/legacy/src/main/java/com/tangem/domain/common/LogConfig.kt
+++ b/domain/legacy/src/main/java/com/tangem/domain/common/LogConfig.kt
@@ -4,17 +4,17 @@ import com.tangem.domain.features.BuildConfig
object LogConfig {
const val imageLoader: Boolean = false
- val storeAction: Boolean = BuildConfig.LOG_ENABLED
+ val shouldStoreAction: Boolean = BuildConfig.LOG_ENABLED
val network: NetworkLogConfig = NetworkLogConfig
val analyticsHandlers: AnalyticsHandlersLogConfig = AnalyticsHandlersLogConfig
}
object NetworkLogConfig {
- val blockchainSdkNetwork: Boolean = BuildConfig.LOG_ENABLED
+ val isBlockchainSdkNetworkLogEnabled: Boolean = BuildConfig.LOG_ENABLED
}
object AnalyticsHandlersLogConfig {
- val firebase: Boolean = BuildConfig.LOG_ENABLED
- val amplitude: Boolean = BuildConfig.LOG_ENABLED
- val appsflyer: Boolean = BuildConfig.LOG_ENABLED
+ val isFirebaseLogEnabled: Boolean = BuildConfig.LOG_ENABLED
+ val isAmplitudeLogEnabled: Boolean = BuildConfig.LOG_ENABLED
+ val isAppsflyerLogEnabled: Boolean = BuildConfig.LOG_ENABLED
}
\ No newline at end of file
diff --git a/domain/manage-tokens/detekt-baseline-debug.xml b/domain/manage-tokens/detekt-baseline-debug.xml
deleted file mode 100644
index 5c9a9d5ec2..0000000000
--- a/domain/manage-tokens/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
- NamedArguments:CheckIsCurrencyNotAddedUseCase.kt$CheckIsCurrencyNotAddedUseCase$isCurrencyNotAdded(userWalletId, networkId, derivationPath, contractAddress)
- NamedArguments:CreateCryptoCurrencyUseCase.kt$CreateCryptoCurrencyUseCase$createCustomToken(userWalletId, networkId, derivationPath, formValues)
- NamedArguments:ValidateTokenFormUseCase.kt$ValidateTokenFormUseCase$zipOrAccumulate( { ensureIsContractAddressValid(formValues.contractAddress, networkId) }, { ensureIsDecimalsValid(formValues.decimals) }, { ensure(formValues.name.isNotBlank()) { CustomTokenFormValidationException.EmptyName } }, { ensure(formValues.symbol.isNotBlank()) { CustomTokenFormValidationException.EmptySymbol } }, ) { contractAddress, decimals, _, _ -> AddCustomTokenForm.Validated.All( contractAddress = contractAddress, symbol = formValues.symbol, name = formValues.name, decimals = decimals, ) }
-
-
diff --git a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CheckIsCurrencyNotAddedUseCase.kt b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CheckIsCurrencyNotAddedUseCase.kt
index e6bd36e0a3..51b7543912 100644
--- a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CheckIsCurrencyNotAddedUseCase.kt
+++ b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CheckIsCurrencyNotAddedUseCase.kt
@@ -15,6 +15,11 @@ class CheckIsCurrencyNotAddedUseCase(
derivationPath: Network.DerivationPath,
contractAddress: String?,
): Either = Either.catch {
- repository.isCurrencyNotAdded(userWalletId, networkId, derivationPath, contractAddress)
+ repository.isCurrencyNotAdded(
+ userWalletId = userWalletId,
+ networkId = networkId,
+ derivationPath = derivationPath,
+ contractAddress = contractAddress,
+ )
}
}
\ No newline at end of file
diff --git a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CreateCryptoCurrencyUseCase.kt b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CreateCryptoCurrencyUseCase.kt
index 1b305b4812..359c4011fb 100644
--- a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CreateCryptoCurrencyUseCase.kt
+++ b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/CreateCryptoCurrencyUseCase.kt
@@ -57,9 +57,18 @@ class CreateCryptoCurrencyUseCase(
formValues: AddCustomTokenForm.Validated.All?,
): Either = Either.catch {
if (formValues == null) {
- customTokensRepository.createCoin(userWalletId, networkId, derivationPath)
+ customTokensRepository.createCoin(
+ userWalletId = userWalletId,
+ networkId = networkId,
+ derivationPath = derivationPath,
+ )
} else {
- customTokensRepository.createCustomToken(userWalletId, networkId, derivationPath, formValues)
+ customTokensRepository.createCustomToken(
+ userWalletId = userWalletId,
+ networkId = networkId,
+ derivationPath = derivationPath,
+ formValues = formValues,
+ )
}
}
}
\ No newline at end of file
diff --git a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/ValidateTokenFormUseCase.kt b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/ValidateTokenFormUseCase.kt
index d909ca4c6a..30ec3baf72 100644
--- a/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/ValidateTokenFormUseCase.kt
+++ b/domain/manage-tokens/src/main/kotlin/com/tangem/domain/managetokens/ValidateTokenFormUseCase.kt
@@ -12,6 +12,7 @@ class ValidateTokenFormUseCase(
private val repository: CustomTokensRepository,
) {
+ @Suppress("NamedArguments")
suspend operator fun invoke(
networkId: Network.ID,
formValues: AddCustomTokenForm.Raw,
diff --git a/domain/promo/src/main/java/com/tangem/domain/promo/PromoRepository.kt b/domain/promo/src/main/java/com/tangem/domain/promo/PromoRepository.kt
index 18d7a50ec4..d8ea76a512 100644
--- a/domain/promo/src/main/java/com/tangem/domain/promo/PromoRepository.kt
+++ b/domain/promo/src/main/java/com/tangem/domain/promo/PromoRepository.kt
@@ -16,7 +16,7 @@ interface PromoRepository {
suspend fun setNeverToShowTokenPromo(promoId: PromoId)
- suspend fun isMarketsStakingNotificationHideClicked(): Flow
+ fun isMarketsStakingNotificationHideClicked(): Flow
suspend fun setMarketsStakingNotificationHideClicked()
// endregion
diff --git a/features/account/api/detekt-baseline-debug.xml b/features/account/api/detekt-baseline-debug.xml
deleted file mode 100644
index 1e04f9d55a..0000000000
--- a/features/account/api/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,8 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:PortfolioFetcher.kt$PortfolioFetcher.Mode.All$val onlyMultiCurrency: Boolean
- UseSumOfInsteadOfFlatMapSize:PortfolioFetcher.kt$PortfolioFetcher.Data$flatten()
-
-
diff --git a/features/account/api/src/main/java/com/tangem/features/account/PortfolioFetcher.kt b/features/account/api/src/main/java/com/tangem/features/account/PortfolioFetcher.kt
index 1884981a50..a56d06a5dd 100644
--- a/features/account/api/src/main/java/com/tangem/features/account/PortfolioFetcher.kt
+++ b/features/account/api/src/main/java/com/tangem/features/account/PortfolioFetcher.kt
@@ -26,7 +26,7 @@ interface PortfolioFetcher {
val isSingleChoice: Boolean = balances.values
.map { it.accountsBalance.accountStatuses }
- .flatten().size == 1
+ .sumOf { it.size } == 1
fun isSingleChoice(walletId: UserWalletId): Boolean = balances[walletId]
?.accountsBalance
@@ -43,7 +43,7 @@ interface PortfolioFetcher {
}
sealed interface Mode {
- data class All(val onlyMultiCurrency: Boolean) : Mode
+ data class All(val isOnlyMultiCurrency: Boolean) : Mode
data class Wallet(val walletId: UserWalletId) : Mode
}
diff --git a/features/account/impl/src/main/java/com/tangem/features/account/fetcher/DefaultPortfolioFetcher.kt b/features/account/impl/src/main/java/com/tangem/features/account/fetcher/DefaultPortfolioFetcher.kt
index fcdd27ea9d..f8bf368a40 100644
--- a/features/account/impl/src/main/java/com/tangem/features/account/fetcher/DefaultPortfolioFetcher.kt
+++ b/features/account/impl/src/main/java/com/tangem/features/account/fetcher/DefaultPortfolioFetcher.kt
@@ -72,7 +72,7 @@ internal class DefaultPortfolioFetcher @AssistedInject constructor(
private fun List.filterWallets(mode: Mode): List = this.filter { wallet ->
when (mode) {
- is Mode.All -> if (mode.onlyMultiCurrency) wallet.isMultiCurrency else true
+ is Mode.All -> if (mode.isOnlyMultiCurrency) wallet.isMultiCurrency else true
is Mode.Wallet -> wallet.walletId == mode.walletId
}
}
diff --git a/features/biometry/impl/detekt-baseline-debug.xml b/features/biometry/impl/detekt-baseline-debug.xml
deleted file mode 100644
index f439e02f2e..0000000000
--- a/features/biometry/impl/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:AskBiometryUM.kt$AskBiometryUM$val bottomSheetVariant: Boolean = false
- BooleanPropertyNaming:AskBiometryUM.kt$AskBiometryUM$val showProgress: Boolean = false
- BooleanPropertyNaming:DefaultAskBiometryComponent.kt$DefaultAskBiometryComponent$val bsShown by bsShown.collectAsStateWithLifecycle()
- MultilineLambdaItParameter:AskBiometryModel.kt$AskBiometryModel${ uiMessageSender.send( SnackbarMessage(stringReference("Something went wrong. Please contact support: $it")), ) }
-
-
diff --git a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/DefaultAskBiometryComponent.kt b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/DefaultAskBiometryComponent.kt
index 81ca241043..4fb9e79cd1 100644
--- a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/DefaultAskBiometryComponent.kt
+++ b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/DefaultAskBiometryComponent.kt
@@ -41,10 +41,10 @@ internal class DefaultAskBiometryComponent @AssistedInject constructor(
@Composable
override fun BottomSheet() {
val state by model.uiState.collectAsStateWithLifecycle()
- val bsShown by bsShown.collectAsStateWithLifecycle()
- val bsConfig = remember(this, bsShown) {
+ val isBSShown by bsShown.collectAsStateWithLifecycle()
+ val bsConfig = remember(this, isBSShown) {
TangemBottomSheetConfig(
- isShown = bsShown,
+ isShown = isBSShown,
onDismissRequest = ::dismiss,
content = TangemBottomSheetConfigContent.Empty,
)
diff --git a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/model/AskBiometryModel.kt b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/model/AskBiometryModel.kt
index b6f43fdbbe..2d586fad73 100644
--- a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/model/AskBiometryModel.kt
+++ b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/model/AskBiometryModel.kt
@@ -55,7 +55,7 @@ internal class AskBiometryModel @Inject constructor(
private val _uiState = MutableStateFlow(
AskBiometryUM(
- bottomSheetVariant = params.isBottomSheetVariant,
+ isBottomSheetVariant = params.isBottomSheetVariant,
onAllowClick = ::onAllowClick,
onDontAllowClick = ::dontAllow,
onDismiss = ::dismiss,
@@ -85,7 +85,7 @@ internal class AskBiometryModel @Inject constructor(
return@launch
}
- _uiState.update { it.copy(showProgress = true) }
+ _uiState.update { it.copy(shouldShowProgress = true) }
/*
@@ -96,7 +96,7 @@ internal class AskBiometryModel @Inject constructor(
uiMessageSender.send(
SnackbarMessage(stringReference("No selected user wallet")),
)
- _uiState.update { it.copy(showProgress = false) }
+ _uiState.update { it.copy(shouldShowProgress = false) }
return@launch
}
@@ -128,7 +128,7 @@ internal class AskBiometryModel @Inject constructor(
}
}
- if (_uiState.value.bottomSheetVariant) {
+ if (_uiState.value.isBottomSheetVariant) {
dismissBSFlow.emit(Unit)
delay(timeMillis = 500)
}
@@ -142,9 +142,9 @@ internal class AskBiometryModel @Inject constructor(
userWalletId = userWallet.walletId,
lockMethod = UserWalletsListRepository.LockMethod.Biometric,
changeUnsecured = false,
- ).onLeft {
+ ).onLeft { error ->
uiMessageSender.send(
- SnackbarMessage(stringReference("Something went wrong. Please contact support: $it")),
+ SnackbarMessage(stringReference("Something went wrong. Please contact support: $error")),
)
}
}
diff --git a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/AskBiometry.kt b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/AskBiometry.kt
index cd367b9850..a3726bf381 100644
--- a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/AskBiometry.kt
+++ b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/AskBiometry.kt
@@ -29,7 +29,7 @@ internal fun AskBiometry(state: AskBiometryUM, modifier: Modifier = Modifier) {
Column(
modifier = Modifier.weight(1f),
) {
- if (state.bottomSheetVariant) {
+ if (state.isBottomSheetVariant) {
Header(onCloseClick = state.onDismiss)
}
@@ -128,12 +128,12 @@ private fun Footer(state: AskBiometryUM, modifier: Modifier = Modifier) {
) {
PrimaryButton(
modifier = Modifier.fillMaxWidth(),
- showProgress = state.showProgress,
+ showProgress = state.shouldShowProgress,
text = stringResourceSafe(id = R.string.save_user_wallet_agreement_allow_biometrics),
onClick = state.onAllowClick,
)
- if (state.bottomSheetVariant.not()) {
+ if (state.isBottomSheetVariant.not()) {
SpacerH12()
SecondaryButton(
@@ -199,7 +199,7 @@ private fun Preview() {
private fun PreviewBS() {
TangemThemePreview {
AskBiometry(
- state = AskBiometryUM(bottomSheetVariant = true),
+ state = AskBiometryUM(isBottomSheetVariant = true),
)
}
}
\ No newline at end of file
diff --git a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/state/AskBiometryUM.kt b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/state/AskBiometryUM.kt
index 0148aba873..88ed6c696b 100644
--- a/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/state/AskBiometryUM.kt
+++ b/features/biometry/impl/src/main/kotlin/com/tangem/features/biometry/impl/ui/state/AskBiometryUM.kt
@@ -3,8 +3,8 @@ package com.tangem.features.biometry.impl.ui.state
import com.tangem.core.ui.extensions.TextReference
internal data class AskBiometryUM(
- val bottomSheetVariant: Boolean = false,
- val showProgress: Boolean = false,
+ val isBottomSheetVariant: Boolean = false,
+ val shouldShowProgress: Boolean = false,
val error: TextReference? = null,
val onAllowClick: () -> Unit = {},
val onDontAllowClick: () -> Unit = {},
diff --git a/features/create-wallet-start/impl/detekt-baseline-debug.xml b/features/create-wallet-start/impl/detekt-baseline-debug.xml
deleted file mode 100644
index 7090dd6ebf..0000000000
--- a/features/create-wallet-start/impl/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:CreateWalletStartUM.kt$CreateWalletStartUM$val showScanSecondaryButton: Boolean
- MultilineLambdaItParameter:CreateWalletStartContent.kt${ FeatureItem( iconResId = it.iconResId, text = it.text, ) }
- MultilineLambdaItParameter:CreateWalletStartModel.kt$CreateWalletStartModel${ delay(HIDE_PROGRESS_DELAY) setLoading(false) when (it) { is SaveWalletError.DataError -> Timber.e(it.toString(), "Unable to save user wallet") is SaveWalletError.WalletAlreadySaved -> { userWalletsListRepository.unlock( userWalletId = userWallet.walletId, unlockMethod = UserWalletsListRepository.UnlockMethod.Scan(scanResponse), ).onRight { appRouter.replaceAll(AppRoute.Wallet) } } } }
-
-
diff --git a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/CreateWalletStartModel.kt b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/CreateWalletStartModel.kt
index c0051682a8..4d1739bbe3 100644
--- a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/CreateWalletStartModel.kt
+++ b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/CreateWalletStartModel.kt
@@ -84,7 +84,7 @@ internal class CreateWalletStartModel @Inject constructor(
),
),
imageResId = R.drawable.img_hardware_wallet,
- showScanSecondaryButton = true,
+ shouldShowScanSecondaryButton = true,
onPrimaryButtonClick = ::onBuyClick,
primaryButtonText = resourceReference(R.string.details_buy_wallet),
otherMethodTitle = resourceReference(R.string.welcome_create_wallet_mobile_title),
@@ -112,7 +112,7 @@ internal class CreateWalletStartModel @Inject constructor(
),
),
imageResId = R.drawable.img_mobile_wallet,
- showScanSecondaryButton = false,
+ shouldShowScanSecondaryButton = false,
onPrimaryButtonClick = ::onStartWithMobileWalletClick,
primaryButtonText = resourceReference(R.string.welcome_create_wallet_mobile_title),
otherMethodTitle = resourceReference(R.string.welcome_create_wallet_use_hardware_title),
@@ -182,11 +182,11 @@ internal class CreateWalletStartModel @Inject constructor(
}
saveWalletUseCase(userWallet = userWallet).fold(
- ifLeft = {
+ ifLeft = { error ->
delay(HIDE_PROGRESS_DELAY)
setLoading(false)
- when (it) {
- is SaveWalletError.DataError -> Timber.e(it.toString(), "Unable to save user wallet")
+ when (error) {
+ is SaveWalletError.DataError -> Timber.e(error.toString(), "Unable to save user wallet")
is SaveWalletError.WalletAlreadySaved -> {
userWalletsListRepository.unlock(
userWalletId = userWallet.walletId,
diff --git a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/entity/CreateWalletStartUM.kt b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/entity/CreateWalletStartUM.kt
index 58f58d2bc0..b45777a20a 100644
--- a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/entity/CreateWalletStartUM.kt
+++ b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/entity/CreateWalletStartUM.kt
@@ -9,7 +9,7 @@ internal data class CreateWalletStartUM(
val featureItems: ImmutableList,
val imageResId: Int,
val isScanInProgress: Boolean,
- val showScanSecondaryButton: Boolean,
+ val shouldShowScanSecondaryButton: Boolean,
val primaryButtonText: TextReference,
val onPrimaryButtonClick: () -> Unit,
val otherMethodDescription: TextReference,
diff --git a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/ui/CreateWalletStartContent.kt b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/ui/CreateWalletStartContent.kt
index 64070ed61e..ecf741b0f0 100644
--- a/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/ui/CreateWalletStartContent.kt
+++ b/features/create-wallet-start/impl/src/main/kotlin/com/tangem/features/createwalletstart/ui/CreateWalletStartContent.kt
@@ -120,10 +120,10 @@ internal fun CreateWalletStartContent(state: CreateWalletStartUM, modifier: Modi
horizontalArrangement = Arrangement.Center,
verticalArrangement = Arrangement.spacedBy(8.dp),
) {
- state.featureItems.forEach {
+ state.featureItems.forEach { item ->
FeatureItem(
- iconResId = it.iconResId,
- text = it.text,
+ iconResId = item.iconResId,
+ text = item.text,
)
}
}
@@ -143,7 +143,7 @@ internal fun CreateWalletStartContent(state: CreateWalletStartUM, modifier: Modi
)
},
bottomContent = {
- if (state.showScanSecondaryButton) {
+ if (state.shouldShowScanSecondaryButton) {
SecondaryButtonIconEnd(
modifier = Modifier
.fillMaxWidth()
@@ -232,7 +232,7 @@ internal fun CreateWalletStartContent(state: CreateWalletStartUM, modifier: Modi
minImageHeight = 160.dp,
)
}
- if (!state.showScanSecondaryButton) {
+ if (!state.shouldShowScanSecondaryButton) {
FlowRow(
modifier = Modifier
.wrapContentWidth()
@@ -425,7 +425,7 @@ private class CreateWalletStartStateProvider : CollectionPreviewParameterProvide
),
),
imageResId = R.drawable.img_hardware_wallet,
- showScanSecondaryButton = true,
+ shouldShowScanSecondaryButton = true,
onPrimaryButtonClick = { },
primaryButtonText = resourceReference(R.string.details_buy_wallet),
otherMethodTitle = resourceReference(R.string.welcome_create_wallet_mobile_title),
@@ -455,7 +455,7 @@ private class CreateWalletStartStateProvider : CollectionPreviewParameterProvide
),
),
imageResId = R.drawable.img_mobile_wallet,
- showScanSecondaryButton = false,
+ shouldShowScanSecondaryButton = false,
onPrimaryButtonClick = { },
primaryButtonText = resourceReference(R.string.welcome_create_wallet_mobile_title),
otherMethodTitle = resourceReference(R.string.welcome_create_wallet_use_hardware_title),
diff --git a/features/markets/impl/src/main/kotlin/com/tangem/features/markets/portfolio/add/impl/ui/DefaultAddToPortfolioManager.kt b/features/markets/impl/src/main/kotlin/com/tangem/features/markets/portfolio/add/impl/ui/DefaultAddToPortfolioManager.kt
index c68c7b7ad5..9c82131fe6 100644
--- a/features/markets/impl/src/main/kotlin/com/tangem/features/markets/portfolio/add/impl/ui/DefaultAddToPortfolioManager.kt
+++ b/features/markets/impl/src/main/kotlin/com/tangem/features/markets/portfolio/add/impl/ui/DefaultAddToPortfolioManager.kt
@@ -31,7 +31,7 @@ internal class DefaultAddToPortfolioManager @AssistedInject constructor(
override val allAvailableNetworks: Flow> = _allAvailableNetworks.asSharedFlow()
override val portfolioFetcher: PortfolioFetcher = portfolioFetcherFactory.create(
- mode = PortfolioFetcher.Mode.All(onlyMultiCurrency = true),
+ mode = PortfolioFetcher.Mode.All(isOnlyMultiCurrency = true),
scope = scope,
)
diff --git a/features/referral/domain/detekt-baseline-debug.xml b/features/referral/domain/detekt-baseline-debug.xml
deleted file mode 100644
index 822bbfee9f..0000000000
--- a/features/referral/domain/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,10 +0,0 @@
-
-
-
-
- MultilineLambdaItParameter:ReferralInteractorImpl.kt$ReferralInteractorImpl${ Timber.e("Failed to derive public keys: $it") throw it.mapToDomainError() }
- ObjectExtendsThrowable:ReferralError.kt$ReferralError$SdkError : ReferralError
- ObjectExtendsThrowable:ReferralError.kt$ReferralError$UserCancelledException : ReferralError
- UselessCallOnNotNull:ReferralInteractorImpl.kt$ReferralInteractorImpl$listOfNotNull(cryptoCurrency)
-
-
diff --git a/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/ReferralInteractorImpl.kt b/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/ReferralInteractorImpl.kt
index 78d092c2da..02ddfaaf01 100644
--- a/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/ReferralInteractorImpl.kt
+++ b/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/ReferralInteractorImpl.kt
@@ -72,9 +72,9 @@ internal class ReferralInteractorImpl(
manageCryptoCurrenciesUseCase(accountId = portfolioId.accountId, add = cryptoCurrency)
}
is PortfolioId.Wallet -> {
- derivePublicKeysUseCase(userWallet.walletId, listOfNotNull(cryptoCurrency)).getOrElse {
- Timber.e("Failed to derive public keys: $it")
- throw it.mapToDomainError()
+ derivePublicKeysUseCase(userWallet.walletId, listOf(cryptoCurrency)).getOrElse { throwable ->
+ Timber.e("Failed to derive public keys: $throwable")
+ throw throwable.mapToDomainError()
}
addCryptoCurrenciesUseCase(
@@ -118,9 +118,9 @@ internal class ReferralInteractorImpl(
private fun Throwable.mapToDomainError(): ReferralError {
if (this !is TangemSdkError) return ReferralError.DataError(this)
return if (this is TangemSdkError.UserCancelled) {
- ReferralError.UserCancelledException
+ ReferralError.UserCancelledException()
} else {
- ReferralError.SdkError
+ ReferralError.SdkError()
}
}
}
\ No newline at end of file
diff --git a/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/errors/ReferralError.kt b/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/errors/ReferralError.kt
index 8d78d31fdd..05e5eac920 100644
--- a/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/errors/ReferralError.kt
+++ b/features/referral/domain/src/main/java/com/tangem/feature/referral/domain/errors/ReferralError.kt
@@ -1,8 +1,8 @@
package com.tangem.feature.referral.domain.errors
sealed class ReferralError : Exception() {
- data object UserCancelledException : ReferralError()
- data object SdkError : ReferralError()
+ class UserCancelledException : ReferralError()
+ class SdkError : ReferralError()
- data class DataError(val throwable: Throwable) : ReferralError()
+ class DataError(val throwable: Throwable) : ReferralError()
}
\ No newline at end of file
diff --git a/features/tangempay/onboarding/impl/detekt-baseline-debug.xml b/features/tangempay/onboarding/impl/detekt-baseline-debug.xml
deleted file mode 100644
index 244ca0e5f5..0000000000
--- a/features/tangempay/onboarding/impl/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
- MultilineLambdaItParameter:TangemPayOnboardingModel.kt$TangemPayOnboardingModel${ TangemPayOnboardingScreenState.Content( onBack = it.onBack, onTermsClick = ::onTermsClick, buttonConfig = TangemPayOnboardingScreenState.Content.ButtonConfig( isLoading = false, onClick = ::onGetCardClick, ), ) }
- MultilineLambdaItParameter:TangemPayOnboardingModel.kt$TangemPayOnboardingModel${ Timber.e("Error getCustomerInfo: ${it.errorCode}") uiState.transformerUpdate(TangemPayOnboardingButtonLoadingTransformer(isLoading = false)) }
- NullableToStringCall:TangemPayOnboardingModel.kt$TangemPayOnboardingModel$${result.leftOrNull()?.message}
-
-
diff --git a/features/tangempay/onboarding/impl/src/main/kotlin/com/tangem/features/tangempay/model/TangemPayOnboardingModel.kt b/features/tangempay/onboarding/impl/src/main/kotlin/com/tangem/features/tangempay/model/TangemPayOnboardingModel.kt
index 688336b8ca..4947048c06 100644
--- a/features/tangempay/onboarding/impl/src/main/kotlin/com/tangem/features/tangempay/model/TangemPayOnboardingModel.kt
+++ b/features/tangempay/onboarding/impl/src/main/kotlin/com/tangem/features/tangempay/model/TangemPayOnboardingModel.kt
@@ -56,9 +56,9 @@ internal class TangemPayOnboardingModel @Inject constructor(
}
private fun showOnboarding() {
- uiState.update {
+ uiState.update { state ->
TangemPayOnboardingScreenState.Content(
- onBack = it.onBack,
+ onBack = state.onBack,
onTermsClick = ::onTermsClick,
buttonConfig = TangemPayOnboardingScreenState.Content.ButtonConfig(
isLoading = false,
@@ -92,6 +92,7 @@ internal class TangemPayOnboardingModel @Inject constructor(
urlOpener.openUrl(TangemPayConstants.TERMS_AND_LIMITS_LINK)
}
+ @Suppress("NullableToStringCall")
private fun onGetCardClick() {
uiState.transformerUpdate(TangemPayOnboardingButtonLoadingTransformer(isLoading = true))
modelScope.launch {
@@ -108,8 +109,8 @@ internal class TangemPayOnboardingModel @Inject constructor(
repository.getCustomerInfo(
userWalletId = userWalletId,
).fold(
- ifLeft = {
- Timber.e("Error getCustomerInfo: ${it.errorCode}")
+ ifLeft = { error ->
+ Timber.e("Error getCustomerInfo: ${error.errorCode}")
uiState.transformerUpdate(TangemPayOnboardingButtonLoadingTransformer(isLoading = false))
},
ifRight = { customerInfo ->
diff --git a/features/txhistory/impl/detekt-baseline-debug.xml b/features/txhistory/impl/detekt-baseline-debug.xml
deleted file mode 100644
index 7a98042e54..0000000000
--- a/features/txhistory/impl/detekt-baseline-debug.xml
+++ /dev/null
@@ -1,9 +0,0 @@
-
-
-
-
- BooleanPropertyNaming:TxHistoryListManager.kt$TxHistoryListManager$val clearUiBatches = state.status is PaginationStatus.InitialLoading && batchListState.status is PaginationStatus.Paginating
- MultilineLambdaItParameter:TxHistoryUiManager.kt$TxHistoryUiManager${ it.status !is PaginationStatus.None && it.status !is PaginationStatus.InitialLoading && it.status !is PaginationStatus.InitialLoadingError }
- UseEmptyCounterpart:TxHistoryListState.kt$TxHistoryListState$listOf()
-
-
diff --git a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListManager.kt b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListManager.kt
index 1c8153f1cb..485c064e0a 100644
--- a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListManager.kt
+++ b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListManager.kt
@@ -88,13 +88,13 @@ internal class TxHistoryListManager(
private fun updateState(batchListState: BatchListState>) {
state.update { state ->
- val clearUiBatches =
+ val shouldClearUiBatches =
state.status is PaginationStatus.InitialLoading && batchListState.status is PaginationStatus.Paginating
state.copy(
status = batchListState.status,
uiBatches = uiManager.createOrUpdateUiBatches(
newCurrencyBatches = batchListState.data,
- clearUiBatches = clearUiBatches,
+ shouldClearUiBatches = shouldClearUiBatches,
),
)
}
diff --git a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListState.kt b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListState.kt
index 8e553fe6ac..e27adfb4ce 100644
--- a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListState.kt
+++ b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryListState.kt
@@ -6,5 +6,5 @@ import com.tangem.pagination.PaginationStatus
data class TxHistoryListState(
val status: PaginationStatus<*> = PaginationStatus.None,
- val uiBatches: List>> = listOf(),
+ val uiBatches: List>> = emptyList(),
)
\ No newline at end of file
diff --git a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryUiManager.kt b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryUiManager.kt
index 3bf17cde84..84a2b5be73 100644
--- a/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryUiManager.kt
+++ b/features/txhistory/impl/src/main/kotlin/com/tangem/features/txhistory/utils/TxHistoryUiManager.kt
@@ -22,10 +22,10 @@ internal class TxHistoryUiManager(
@OptIn(ExperimentalCoroutinesApi::class)
val items: Flow> = state
// filter initial states, since we dont emit loading items as UI items
- .filter {
- it.status !is PaginationStatus.None &&
- it.status !is PaginationStatus.InitialLoading &&
- it.status !is PaginationStatus.InitialLoadingError
+ .filter { state ->
+ state.status !is PaginationStatus.None &&
+ state.status !is PaginationStatus.InitialLoading &&
+ state.status !is PaginationStatus.InitialLoadingError
}
.mapLatest { state ->
state.uiBatches.asSequence()
@@ -36,10 +36,10 @@ internal class TxHistoryUiManager(
fun createOrUpdateUiBatches(
newCurrencyBatches: List>>,
- clearUiBatches: Boolean,
+ shouldClearUiBatches: Boolean,
): List>> {
val currentUiBatches = state.value.uiBatches
- val batches = if (clearUiBatches) mutableListOf() else currentUiBatches.toMutableList()
+ val batches = if (shouldClearUiBatches) mutableListOf() else currentUiBatches.toMutableList()
for ((key, data) in newCurrencyBatches) {
// Find if batch with same key exists
diff --git a/features/wallet-settings/impl/src/main/kotlin/com/tangem/feature/walletsettings/model/WalletSettingsModel.kt b/features/wallet-settings/impl/src/main/kotlin/com/tangem/feature/walletsettings/model/WalletSettingsModel.kt
index 826d89ac75..a44d3ead1c 100644
--- a/features/wallet-settings/impl/src/main/kotlin/com/tangem/feature/walletsettings/model/WalletSettingsModel.kt
+++ b/features/wallet-settings/impl/src/main/kotlin/com/tangem/feature/walletsettings/model/WalletSettingsModel.kt
@@ -438,7 +438,7 @@ internal class WalletSettingsModel @Inject constructor(
AppRoute.CreateWalletBackup(
userWalletId = params.userWalletId,
isUpgradeFlow = isUpgradeFlow,
- setAccessCode = true,
+ shouldSetAccessCode = true,
analyticsSource = AnalyticsParam.ScreensSources.WalletSettings.value,
analyticsAction = if (isUpgradeFlow) {
RecoveryPhraseScreenAction.Backup.value
diff --git a/features/wallet/impl/detekt-baseline-debug.xml b/features/wallet/impl/detekt-baseline-debug.xml
index c83e37ad72..5a9fa2634b 100644
--- a/features/wallet/impl/detekt-baseline-debug.xml
+++ b/features/wallet/impl/detekt-baseline-debug.xml
@@ -71,7 +71,6 @@
MultilineLambdaItParameter:WalletCurrencyActionsClickIntents.kt$WalletCurrencyActionsClickIntentsImplementor${ analyticsEventHandler.send(TokenReceiveAnalyticsEvent.ButtonShareAddress(currency.symbol)) shareManager.shareText(text = it) }
MultilineLambdaItParameter:WalletCurrencyActionsClickIntents.kt$WalletCurrencyActionsClickIntentsImplementor${ onAddressTypeSelected( userWalletId = userWalletId, currency = currency, addressModel = it, ) }
MultilineLambdaItParameter:WalletLoaderStorage.kt$WalletLoaderStorage${ it.forEach(Job::cancel) loaders.remove(id) }
- MultilineLambdaItParameter:WalletModel.kt$WalletModel${ it .conflate() .distinctUntilChanged() .onEach { selectedWallet -> if (selectedWallet.isMultiCurrency) { selectedWalletAnalyticsSender.send(selectedWallet) } subscribeOnExpressTransactionsUpdates(selectedWallet) observeAndClearNFTCacheIfNeedUseCase(selectedWallet) } .flowOn(dispatchers.main) .launchIn(modelScope) }
MultilineLambdaItParameter:WalletModel.kt$WalletModel${ walletScreenContentLoader.load( userWallet = it, clickIntents = clickIntents, coroutineScope = modelScope, isRefresh = true, ) }
MultilineLambdaItParameter:WalletModel.kt$WalletModel${ walletsUpdateActionResolver.resolve( wallets = it, currentState = stateHolder.value, ) }
MultilineLambdaItParameter:WalletNFTListSubscriber.kt$WalletNFTListSubscriber${ stateHolder.update( SetNFTCollectionsTransformer( userWalletId = userWallet.walletId, nftCollections = it, onItemClick = { clickIntents.onNFTClick(userWallet) }, ), ) }
diff --git a/features/walletconnect/impl/src/main/kotlin/com/tangem/features/walletconnect/connections/model/WcPairModel.kt b/features/walletconnect/impl/src/main/kotlin/com/tangem/features/walletconnect/connections/model/WcPairModel.kt
index aaf93e1932..76072cedae 100644
--- a/features/walletconnect/impl/src/main/kotlin/com/tangem/features/walletconnect/connections/model/WcPairModel.kt
+++ b/features/walletconnect/impl/src/main/kotlin/com/tangem/features/walletconnect/connections/model/WcPairModel.kt
@@ -118,7 +118,7 @@ internal class WcPairModel @Inject constructor(
init {
if (accountsFeatureToggles.isFeatureEnabled) {
portfolioFetcher = portfolioFetcherFactory.create(
- mode = PortfolioFetcher.Mode.All(onlyMultiCurrency = true),
+ mode = PortfolioFetcher.Mode.All(isOnlyMultiCurrency = true),
scope = modelScope,
)
modelScope.launch {